Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add JUnit tests for ViewCommandParser and ViewCommand #145

Merged
merged 60 commits into from
Apr 1, 2019
Merged

Add JUnit tests for ViewCommandParser and ViewCommand #145

merged 60 commits into from
Apr 1, 2019

Conversation

dingheng4448
Copy link

No description provided.

@dingheng4448
Planner: Initialize weekType for each Day
92cb2cd
@dingheng4448
Planner: Fix Codacy issue
1a98449
@dingheng4448
Planner: Update code for initialisation of semester
45f7915
@dingheng4448
Planner: Fix Codacy and checkstyle issues
2c631df
@dingheng4448
Merge branch 'master' into develop
20b4abb
@dingheng4448
Planner: Fix build error
5ac6ca9
@dingheng4448
Planner: Dynamic generation of semester from date
7e5b58c
@dingheng4448
PlannerTest: Add JUnit test for generateSemester
60d1cda
@dingheng4448
Merge remote-tracking branch 'origin/develop' into develop
93b40ed 
# Conflicts:
#	src/planmysem/data/Planner.java
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
a8d57fe 
…into develop
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
a002fdc 
…into develop
@dingheng4448
Update documentation for view command
dbcf1fd
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
f3ce309 
…into develop
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
8d35cfb 
…into develop
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
aa42b48 
…into develop
@dingheng4448
Add view command for monthly calendar view
f0d916b
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
132bb01 
…into develop
@dingheng4448
Fix Codacy issue
1eded38
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
db15e14 
…into develop
@dingheng4448
UserGuide: Update user guide documentation
bfac078
@dingheng4448
UserGuide: Update user guide documentation
936a880
@dingheng4448
UserGuide: Update user guide documentation
6c679a2
@dingheng4448
UserGuide: Update user guide documentation
a2c34fa
@dingheng4448
Merge remote-tracking branch 'origin/develop' into develop
732c15e 
# Conflicts:
#	docs/UserGuide.adoc
@dingheng4448
UserGuide: Update user guide documentation
e14f476
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
4b1781b 
…into develop
@dingheng4448
UserGuide: Update user guide documentation
d7cb580
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
24ac7d5 
…into develop
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
9967d8d 
…into develop
@dingheng4448
Moved Semester generation code
17f1e8d
@dingheng4448
Update view command for calendar day view
f3d3b3a
@dingheng4448
Update view command for calendar week view
0006b62
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
873fcb9 
…into develop
@dingheng4448
Update view command for calendar week view
602a0dd
@dingheng4448
Update JUnit test for Planner
82634b3
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
0096e94 
…into develop
@dingheng4448
Update User Guide for view command
19f0c79
@dingheng4448
Update User Guide for view command
018551b
@dingheng4448
Fix Codacy issue
a75c293
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
65fba29 
…into develop
@dingheng4448
DeveloperGuide: Update view feature documentation
a48253d
@dingheng4448
DeveloperGuide: Update view feature documentation
3011d76
@dingheng4448
DeveloperGuide: Update view feature documentation formatting
8c98521
@dingheng4448
DeveloperGuide: Update introduction
2c7bdcf
@dingheng4448
Update ViewCommand and ViewCommandParser
bfa4b63
@dingheng4448
Merge branch 'master' into develop
3427b3b
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
a0d8e6e 
…into develop
@dingheng4448
Merge remote-tracking branch 'origin/develop' into develop
274e8e2
@dingheng4448
Update view command to fix minor bug
1eb6df0
@dingheng4448
Fix Junit test for PlannerTest
19ebab3
@dingheng4448
Add JUnit tests for ViewCommandParser and ViewCommand
365ea65
@dingheng4448
Merge branch 'master' of https://github.com/CS2113-AY1819S2-T08-3/main …
efcf174 
…into develop
@dingheng4448 dingheng4448 added the priority.High Must do label Apr 1, 2019
@dingheng4448 dingheng4448 added this to the v1.3 milestone Apr 1, 2019
@dingheng4448 dingheng4448 self-assigned this Apr 1, 2019
@seanieyap
Copy link

Perfect tests. No issues.

@seanieyap seanieyap merged commit 7852a46 into CS2113-AY1819S2-T08-3:master Apr 1, 2019
marcus-pzj
marcus-pzj reviewed Apr 1, 2019
View reviewed changes
Copy link
Member

@marcus-pzj marcus-pzj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good additions to tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcus-pzj marcus-pzj marcus-pzj left review comments

@seanieyap seanieyap Awaiting requested review from seanieyap

Assignees

@dingheng4448 dingheng4448

Labels
priority.High Must do
Projects
None yet
Milestone
v1.3
Development

Successfully merging this pull request may close these issues.
3 participants
@dingheng4448 @seanieyap @marcus-pzj